Browse Source

helios changes:
- adds "Widget" to widget class names
- adds HLWidget >> openAsWidget

Nicolas Petton 11 years ago
parent
commit
3ec5c7374a

+ 2 - 2
js/Helios-Commands-Tools.deploy.js

@@ -399,10 +399,10 @@ function $HLReferences(){return smalltalk.HLReferences||(typeof HLReferences=="u
 return smalltalk.withContext(function($ctx1) { 
 var $1,$2;
 $1=_st($HLReferences())._new();
-_st($1)._open();
+_st($1)._openAsTab();
 $2=_st($1)._search_(_st(self)._input());
 return self}, function($ctx1) {$ctx1.fill(self,"execute",{},smalltalk.HLFindReferencesCommand)})},
-messageSends: ["open", "new", "search:", "input"]}),
+messageSends: ["openAsTab", "new", "search:", "input"]}),
 smalltalk.HLFindReferencesCommand);
 
 smalltalk.addMethod(

+ 3 - 3
js/Helios-Commands-Tools.js

@@ -555,12 +555,12 @@ function $HLReferences(){return smalltalk.HLReferences||(typeof HLReferences=="u
 return smalltalk.withContext(function($ctx1) { 
 var $1,$2;
 $1=_st($HLReferences())._new();
-_st($1)._open();
+_st($1)._openAsTab();
 $2=_st($1)._search_(_st(self)._input());
 return self}, function($ctx1) {$ctx1.fill(self,"execute",{},smalltalk.HLFindReferencesCommand)})},
 args: [],
-source: "execute\x0a\x09HLReferences new \x0a\x09\x09open;\x0a\x09\x09search: self input",
-messageSends: ["open", "new", "search:", "input"],
+source: "execute\x0a\x09HLReferences new \x0a\x09\x09openAsTab;\x0a\x09\x09search: self input",
+messageSends: ["openAsTab", "new", "search:", "input"],
 referencedClasses: ["HLReferences"]
 }),
 smalltalk.HLFindReferencesCommand);

File diff suppressed because it is too large
+ 177 - 170
js/Helios-Core.deploy.js


File diff suppressed because it is too large
+ 160 - 148
js/Helios-Core.js


+ 2 - 15
js/Helios-Debugger.deploy.js

@@ -190,19 +190,6 @@ return self}, function($ctx1) {$ctx1.fill(self,"onContextSelected:",{anAnnouncem
 messageSends: ["inspect:", "on:", "context", "inspectorWidget"]}),
 smalltalk.HLDebugger);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(_st(self)._class())._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLDebugger)})},
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "class", "current"]}),
-smalltalk.HLDebugger);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "registerBindingsOn:",
@@ -627,13 +614,13 @@ function $HLDebugger(){return smalltalk.HLDebugger||(typeof HLDebugger=="undefin
 return smalltalk.withContext(function($ctx1) { 
 _st((function(){
 return smalltalk.withContext(function($ctx2) {
-return _st(_st($HLDebugger())._on_(_st(anError)._context()))._open();
+return _st(_st($HLDebugger())._on_(_st(anError)._context()))._openAsTab();
 }, function($ctx2) {$ctx2.fillBlock({},$ctx1)})}))._on_do_($Error(),(function(error){
 return smalltalk.withContext(function($ctx2) {
 return _st(_st($ErrorHandler())._new())._handleError_(error);
 }, function($ctx2) {$ctx2.fillBlock({error:error},$ctx1)})}));
 return self}, function($ctx1) {$ctx1.fill(self,"handleError:",{anError:anError},smalltalk.HLErrorHandler)})},
-messageSends: ["on:do:", "handleError:", "new", "open", "on:", "context"]}),
+messageSends: ["on:do:", "handleError:", "new", "openAsTab", "on:", "context"]}),
 smalltalk.HLErrorHandler);
 
 

+ 3 - 21
js/Helios-Debugger.js

@@ -246,24 +246,6 @@ referencedClasses: ["HLContextInspectorDecorator"]
 }),
 smalltalk.HLDebugger);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-category: 'rendering',
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(_st(self)._class())._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLDebugger)})},
-args: [],
-source: "open\x0a\x09HLManager current addTab: (HLTab on: self labelled: self class tabLabel)",
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "class", "current"],
-referencedClasses: ["HLTab", "HLManager"]
-}),
-smalltalk.HLDebugger);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "registerBindingsOn:",
@@ -825,15 +807,15 @@ function $HLDebugger(){return smalltalk.HLDebugger||(typeof HLDebugger=="undefin
 return smalltalk.withContext(function($ctx1) { 
 _st((function(){
 return smalltalk.withContext(function($ctx2) {
-return _st(_st($HLDebugger())._on_(_st(anError)._context()))._open();
+return _st(_st($HLDebugger())._on_(_st(anError)._context()))._openAsTab();
 }, function($ctx2) {$ctx2.fillBlock({},$ctx1)})}))._on_do_($Error(),(function(error){
 return smalltalk.withContext(function($ctx2) {
 return _st(_st($ErrorHandler())._new())._handleError_(error);
 }, function($ctx2) {$ctx2.fillBlock({error:error},$ctx1)})}));
 return self}, function($ctx1) {$ctx1.fill(self,"handleError:",{anError:anError},smalltalk.HLErrorHandler)})},
 args: ["anError"],
-source: "handleError: anError\x0a\x09[ (HLDebugger on: anError context)\x0a\x09\x09open ] on: Error do: [ :error |\x0a\x09\x09\x09ErrorHandler new handleError: error ]",
-messageSends: ["on:do:", "handleError:", "new", "open", "on:", "context"],
+source: "handleError: anError\x0a\x09[ \x0a\x09\x09(HLDebugger on: anError context) openAsTab \x0a\x09] \x0a\x09\x09on: Error \x0a\x09\x09do: [ :error | ErrorHandler new handleError: error ]",
+messageSends: ["on:do:", "handleError:", "new", "openAsTab", "on:", "context"],
 referencedClasses: ["Error", "ErrorHandler", "HLDebugger"]
 }),
 smalltalk.HLErrorHandler);

+ 4 - 17
js/Helios-Inspector.deploy.js

@@ -733,9 +733,9 @@ return smalltalk.withContext(function($ctx1) {
 var $1,$2;
 $1=_st($HLInspector())._new();
 _st($1)._inspect_(_st(_st(self)._model())._selectedInstVarObject());
-$2=_st($1)._open();
+$2=_st($1)._openAsTab();
 return self}, function($ctx1) {$ctx1.fill(self,"onDive",{},smalltalk.HLInspectorWidget)})},
-messageSends: ["inspect:", "selectedInstVarObject", "model", "new", "open"]}),
+messageSends: ["inspect:", "selectedInstVarObject", "model", "new", "openAsTab"]}),
 smalltalk.HLInspectorWidget);
 
 smalltalk.addMethod(
@@ -781,19 +781,6 @@ return self}, function($ctx1) {$ctx1.fill(self,"onPrintIt",{},smalltalk.HLInspec
 messageSends: []}),
 smalltalk.HLInspectorWidget);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(self)._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLInspectorWidget)})},
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "current"]}),
-smalltalk.HLInspectorWidget);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "refresh",
@@ -976,9 +963,9 @@ return smalltalk.withContext(function($ctx1) {
 var $1,$2;
 $1=_st(self)._new();
 _st($1)._inspect_(anObject);
-$2=_st($1)._open();
+$2=_st($1)._openAsTab();
 return self}, function($ctx1) {$ctx1.fill(self,"inspect:",{anObject:anObject},smalltalk.HLInspector.klass)})},
-messageSends: ["inspect:", "new", "open"]}),
+messageSends: ["inspect:", "new", "openAsTab"]}),
 smalltalk.HLInspector.klass);
 
 smalltalk.addMethod(

+ 6 - 24
js/Helios-Inspector.js

@@ -974,11 +974,11 @@ return smalltalk.withContext(function($ctx1) {
 var $1,$2;
 $1=_st($HLInspector())._new();
 _st($1)._inspect_(_st(_st(self)._model())._selectedInstVarObject());
-$2=_st($1)._open();
+$2=_st($1)._openAsTab();
 return self}, function($ctx1) {$ctx1.fill(self,"onDive",{},smalltalk.HLInspectorWidget)})},
 args: [],
-source: "onDive\x0a\x0a\x09HLInspector new \x0a\x09\x09inspect: self model selectedInstVarObject;\x0a\x09\x09open",
-messageSends: ["inspect:", "selectedInstVarObject", "model", "new", "open"],
+source: "onDive\x0a\x0a\x09HLInspector new \x0a\x09\x09inspect: self model selectedInstVarObject;\x0a\x09\x09openAsTab",
+messageSends: ["inspect:", "selectedInstVarObject", "model", "new", "openAsTab"],
 referencedClasses: ["HLInspector"]
 }),
 smalltalk.HLInspectorWidget);
@@ -1046,24 +1046,6 @@ referencedClasses: []
 }),
 smalltalk.HLInspectorWidget);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-category: 'actions',
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(self)._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLInspectorWidget)})},
-args: [],
-source: "open\x0a\x09HLManager current addTab: (HLTab on: self labelled: self tabLabel)",
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "current"],
-referencedClasses: ["HLTab", "HLManager"]
-}),
-smalltalk.HLInspectorWidget);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "refresh",
@@ -1312,11 +1294,11 @@ return smalltalk.withContext(function($ctx1) {
 var $1,$2;
 $1=_st(self)._new();
 _st($1)._inspect_(anObject);
-$2=_st($1)._open();
+$2=_st($1)._openAsTab();
 return self}, function($ctx1) {$ctx1.fill(self,"inspect:",{anObject:anObject},smalltalk.HLInspector.klass)})},
 args: ["anObject"],
-source: "inspect: anObject\x0a\x09self new\x0a\x09\x09inspect: anObject;\x0a\x09\x09open",
-messageSends: ["inspect:", "new", "open"],
+source: "inspect: anObject\x0a\x09self new\x0a\x09\x09inspect: anObject;\x0a\x09\x09openAsTab",
+messageSends: ["inspect:", "new", "openAsTab"],
 referencedClasses: []
 }),
 smalltalk.HLInspector.klass);

+ 0 - 13
js/Helios-References.deploy.js

@@ -183,19 +183,6 @@ return self}, function($ctx1) {$ctx1.fill(self,"model:",{aModel:aModel},smalltal
 messageSends: []}),
 smalltalk.HLReferences);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(_st(self)._class())._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLReferences)})},
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "class", "current"]}),
-smalltalk.HLReferences);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "regexpListWidget",

+ 0 - 18
js/Helios-References.js

@@ -243,24 +243,6 @@ referencedClasses: []
 }),
 smalltalk.HLReferences);
 
-smalltalk.addMethod(
-smalltalk.method({
-selector: "open",
-category: 'actions',
-fn: function (){
-var self=this;
-function $HLTab(){return smalltalk.HLTab||(typeof HLTab=="undefined"?nil:HLTab)}
-function $HLManager(){return smalltalk.HLManager||(typeof HLManager=="undefined"?nil:HLManager)}
-return smalltalk.withContext(function($ctx1) { 
-_st(_st($HLManager())._current())._addTab_(_st($HLTab())._on_labelled_(self,_st(_st(self)._class())._tabLabel()));
-return self}, function($ctx1) {$ctx1.fill(self,"open",{},smalltalk.HLReferences)})},
-args: [],
-source: "open\x0a\x09HLManager current addTab: (HLTab on: self labelled: self class tabLabel)",
-messageSends: ["addTab:", "on:labelled:", "tabLabel", "class", "current"],
-referencedClasses: ["HLTab", "HLManager"]
-}),
-smalltalk.HLReferences);
-
 smalltalk.addMethod(
 smalltalk.method({
 selector: "regexpListWidget",

+ 1 - 1
st/Helios-Commands-Tools.st

@@ -213,7 +213,7 @@ defaultInput
 
 execute
 	HLReferences new 
-		open;
+		openAsTab;
 		search: self input
 ! !
 

+ 50 - 46
st/Helios-Core.st

@@ -134,6 +134,7 @@ selectedMethod: aCompiledMethod
     		ifNil: [ selectedSelector := nil ]
       		ifNotNil: [
 				selectedClass := aCompiledMethod methodClass.
+				selectedPackage := selectedClass theNonMetaClass package.
 				selectedSelector := aCompiledMethod selector ].
 
 		self announcer announce: (HLMethodSelected on: aCompiledMethod) ]
@@ -414,16 +415,16 @@ I am a specific progress handler for Helios, displaying progresses in a modal wi
 !HLProgressHandler methodsFor: 'progress handling'!
 
 do: aBlock on: aCollection displaying: aString
-	HLProgress default
+	HLProgressWidget default
 		do: aBlock 
 		on: aCollection 
 		displaying: aString
 ! !
 
-Widget subclass: #HLTab
+Widget subclass: #HLTabWidget
 	instanceVariableNames: 'widget label root'
 	package: 'Helios-Core'!
-!HLTab commentStamp!
+!HLTabWidget commentStamp!
 I am a widget specialized into building another widget as an Helios tab.
 
 I should not be used directly, `HLWidget class >> #openAsTab` should be used instead.
@@ -432,7 +433,7 @@ I should not be used directly, `HLWidget class >> #openAsTab` should be used ins
 
     HLWorkspace openAsTab!
 
-!HLTab methodsFor: 'accessing'!
+!HLTabWidget methodsFor: 'accessing'!
 
 activate
 	self manager activate: self
@@ -477,7 +478,7 @@ widget: aWidget
 	widget := aWidget
 ! !
 
-!HLTab methodsFor: 'actions'!
+!HLTabWidget methodsFor: 'actions'!
 
 hide
 	root ifNotNil: [ root asJQuery css: 'visibility' put: 'hidden' ]
@@ -498,7 +499,7 @@ show
 		ifNotNil: [ root asJQuery css: 'visibility' put: 'visible' ]
 ! !
 
-!HLTab methodsFor: 'rendering'!
+!HLTabWidget methodsFor: 'rendering'!
 
 renderOn: html
 	root := html div
@@ -514,13 +515,13 @@ renderTab
 			with: [ self widget renderOn: html ] ]
 ! !
 
-!HLTab methodsFor: 'testing'!
+!HLTabWidget methodsFor: 'testing'!
 
 isActive
 	^ self manager activeTab = self
 ! !
 
-!HLTab class methodsFor: 'instance creation'!
+!HLTabWidget class methodsFor: 'instance creation'!
 
 on: aWidget labelled: aString
 	^ self new
@@ -593,6 +594,10 @@ execute: aCommand
 		applyBinding: aCommand asBinding
 !
 
+openAsTab
+	HLManager current addTab: (HLTabWidget on: self labelled: self class tabLabel)
+!
+
 request: aString do: aBlock
 	self manager request: aString do: aBlock
 !
@@ -646,8 +651,7 @@ refresh
 !HLWidget class methodsFor: 'accessing'!
 
 openAsTab
-	self canBeOpenAsTab ifFalse: [ ^ self ].
-	HLManager current addTab: (HLTab on: self new labelled: self tabLabel)
+	HLManager current addTab: (HLTabWidget on: self new labelled: self tabLabel)
 !
 
 tabClass
@@ -1178,7 +1182,7 @@ addToHistory: aTab
 !
 
 confirm: aString ifFalse: aBlock
-	(HLConfirmation new
+	(HLConfirmationWidget new
 		confirmationString: aString;
 		cancelBlock: aBlock;
 		yourself)
@@ -1186,7 +1190,7 @@ confirm: aString ifFalse: aBlock
 !
 
 confirm: aString ifTrue: aBlock
-	(HLConfirmation new
+	(HLConfirmationWidget new
 		confirmationString: aString;
 		actionBlock: aBlock;
 		yourself)
@@ -1233,7 +1237,7 @@ request: aString do: aBlock
 !
 
 request: aString value: valueString do: aBlock
-	(HLRequest new
+	(HLRequestWidget new
 		confirmationString: aString;
 		actionBlock: aBlock;
 		value: valueString;
@@ -1353,19 +1357,19 @@ new
 	self shouldNotImplement
 ! !
 
-HLWidget subclass: #HLModal
+HLWidget subclass: #HLModalWidget
 	instanceVariableNames: ''
 	package: 'Helios-Core'!
-!HLModal commentStamp!
+!HLModalWidget commentStamp!
 I implement an abstract modal widget.!
 
-!HLModal methodsFor: 'accessing'!
+!HLModalWidget methodsFor: 'accessing'!
 
 cssClass
 	^ ''
 ! !
 
-!HLModal methodsFor: 'actions'!
+!HLModalWidget methodsFor: 'actions'!
 
 cancel
 	self remove
@@ -1379,7 +1383,7 @@ remove
 	] valueWithTimeout: 300
 ! !
 
-!HLModal methodsFor: 'rendering'!
+!HLModalWidget methodsFor: 'rendering'!
 
 renderButtonsOn: html
 !
@@ -1407,15 +1411,15 @@ setupKeyBindings
 		e keyCode = 27 ifTrue: [ self cancel ] ]
 ! !
 
-HLModal subclass: #HLConfirmation
+HLModalWidget subclass: #HLConfirmationWidget
 	instanceVariableNames: 'confirmationString actionBlock cancelBlock'
 	package: 'Helios-Core'!
-!HLConfirmation commentStamp!
+!HLConfirmationWidget commentStamp!
 I display confirmation messages. 
 
 Instead of creating an instance directly, use `HLWidget >> #confirm:ifTrue:`.!
 
-!HLConfirmation methodsFor: 'accessing'!
+!HLConfirmationWidget methodsFor: 'accessing'!
 
 actionBlock
 	^ actionBlock ifNil: [ [] ]
@@ -1441,7 +1445,7 @@ confirmationString: aString
 	confirmationString := aString
 ! !
 
-!HLConfirmation methodsFor: 'actions'!
+!HLConfirmationWidget methodsFor: 'actions'!
 
 cancel
 	self cancelBlock value.
@@ -1461,7 +1465,7 @@ remove
 	] valueWithTimeout: 300
 ! !
 
-!HLConfirmation methodsFor: 'rendering'!
+!HLConfirmationWidget methodsFor: 'rendering'!
 
 renderButtonsOn: html
 	| confirmButton |
@@ -1485,15 +1489,15 @@ renderMainOn: html
 	html span with: self confirmationString
 ! !
 
-HLConfirmation subclass: #HLRequest
+HLConfirmationWidget subclass: #HLRequestWidget
 	instanceVariableNames: 'input value'
 	package: 'Helios-Core'!
-!HLRequest commentStamp!
+!HLRequestWidget commentStamp!
 I display a modal window requesting user input.
 
 Instead of creating instances manually, use `HLWidget >> #request:do:` and `#request:value:do:`.!
 
-!HLRequest methodsFor: 'accessing'!
+!HLRequestWidget methodsFor: 'accessing'!
 
 cssClass
 	^ 'large'
@@ -1507,14 +1511,14 @@ value: aString
 	value := aString
 ! !
 
-!HLRequest methodsFor: 'actions'!
+!HLRequestWidget methodsFor: 'actions'!
 
 confirm
 	self actionBlock value: input asJQuery val.
 	self remove
 ! !
 
-!HLRequest methodsFor: 'rendering'!
+!HLRequestWidget methodsFor: 'rendering'!
 
 renderMainOn: html
 	super renderMainOn: html.
@@ -1522,23 +1526,23 @@ renderMainOn: html
 	input asJQuery val: self value
 ! !
 
-HLModal subclass: #HLProgress
+HLModalWidget subclass: #HLProgressWidget
 	instanceVariableNames: 'progressBars visible'
 	package: 'Helios-Core'!
-!HLProgress commentStamp!
+!HLProgressWidget commentStamp!
 I am a widget used to display progress modal dialogs.
 
-My default instance is accessed with `HLProgress >> #default`.
+My default instance is accessed with `HLProgressWidget class >> #default`.
 
-See `HLProgressHandler`.!
+See `HLProgressHandler` for usage.!
 
-!HLProgress methodsFor: 'accessing'!
+!HLProgressWidget methodsFor: 'accessing'!
 
 progressBars
 	^ progressBars ifNil: [ progressBars := OrderedCollection new ]
 ! !
 
-!HLProgress methodsFor: 'actions'!
+!HLProgressWidget methodsFor: 'actions'!
 
 addProgressBar: aProgressBar
 	self show.
@@ -1549,7 +1553,7 @@ addProgressBar: aProgressBar
 do: aBlock on: aCollection displaying: aString
 	| progressBar |
 	
-	progressBar := HLProgressBar new
+	progressBar := HLProgressBarWidget new
 		parent: self;
 		label: aString;
 		workBlock: aBlock;
@@ -1579,7 +1583,7 @@ show
 		self appendToJQuery: 'body' asJQuery ]
 ! !
 
-!HLProgress methodsFor: 'rendering'!
+!HLProgressWidget methodsFor: 'rendering'!
 
 renderButtonsOn: html
 !
@@ -1589,27 +1593,27 @@ renderMainOn: html
 		html with: each ]
 ! !
 
-!HLProgress methodsFor: 'testing'!
+!HLProgressWidget methodsFor: 'testing'!
 
 isVisible
 	^ visible ifNil: [ false ]
 ! !
 
-HLProgress class instanceVariableNames: 'default'!
+HLProgressWidget class instanceVariableNames: 'default'!
 
-!HLProgress class methodsFor: 'accessing'!
+!HLProgressWidget class methodsFor: 'accessing'!
 
 default
 	^ default ifNil: [ default := self new ]
 ! !
 
-HLWidget subclass: #HLProgressBar
+HLWidget subclass: #HLProgressBarWidget
 	instanceVariableNames: 'label parent workBlock collection bar'
 	package: 'Helios-Core'!
-!HLProgressBar commentStamp!
+!HLProgressBarWidget commentStamp!
 I am a widget used to display a progress bar while iterating over a collection.!
 
-!HLProgressBar methodsFor: 'accessing'!
+!HLProgressBarWidget methodsFor: 'accessing'!
 
 collection
 	^ collection
@@ -1643,7 +1647,7 @@ workBlock: aBlock
 	workBlock := aBlock
 ! !
 
-!HLProgressBar methodsFor: 'actions'!
+!HLProgressBarWidget methodsFor: 'actions'!
 
 evaluateAt: anInteger
 	self updateProgress: (anInteger / self collection size) * 100.
@@ -1669,7 +1673,7 @@ updateProgress: anInteger
 	bar asJQuery css: 'width' put: anInteger asString, '%'
 ! !
 
-!HLProgressBar methodsFor: 'rendering'!
+!HLProgressBarWidget methodsFor: 'rendering'!
 
 renderContentOn: html
 	html span with: self label.
@@ -1681,9 +1685,9 @@ renderContentOn: html
 				style: 'width: 0%' ]
 ! !
 
-HLProgressBar class instanceVariableNames: 'default'!
+HLProgressBarWidget class instanceVariableNames: 'default'!
 
-!HLProgressBar class methodsFor: 'accessing'!
+!HLProgressBarWidget class methodsFor: 'accessing'!
 
 default
 	^ default ifNil: [ default := self new ]

+ 5 - 7
st/Helios-Debugger.st

@@ -112,10 +112,6 @@ onContextSelected: anAnnouncement
 
 !HLDebugger methodsFor: 'rendering'!
 
-open
-	HLManager current addTab: (HLTab on: self labelled: self class tabLabel)
-!
-
 renderContentOn: html
 	html with: (HLContainer with: (HLHorizontalSplitter
 		with: self stackListWidget
@@ -311,9 +307,11 @@ ErrorHandler subclass: #HLErrorHandler
 !HLErrorHandler methodsFor: 'error handling'!
 
 handleError: anError
-	[ (HLDebugger on: anError context)
-		open ] on: Error do: [ :error |
-			ErrorHandler new handleError: error ]
+	[ 
+		(HLDebugger on: anError context) openAsTab 
+	] 
+		on: Error 
+		do: [ :error | ErrorHandler new handleError: error ]
 ! !
 
 !HLErrorHandler class methodsFor: 'error handling'!

+ 2 - 6
st/Helios-Inspector.st

@@ -311,10 +311,6 @@ observeVariablesWidget
         on: HLDiveRequested do:[ self onDive ]
 !
 
-open
-	HLManager current addTab: (HLTab on: self labelled: self tabLabel)
-!
-
 refresh
 	self 
 		refreshVariablesWidget;
@@ -343,7 +339,7 @@ onDive
 
 	HLInspector new 
 		inspect: self model selectedInstVarObject;
-		open
+		openAsTab
 !
 
 onDoneIt
@@ -424,7 +420,7 @@ tabPriority
 inspect: anObject
 	self new
 		inspect: anObject;
-		open
+		openAsTab
 ! !
 
 !HLInspector class methodsFor: 'initialization'!

+ 0 - 4
st/Helios-References.st

@@ -95,10 +95,6 @@ sourceCodeWidget
 
 !HLReferences methodsFor: 'actions'!
 
-open
-	HLManager current addTab: (HLTab on: self labelled: self class tabLabel)
-!
-
 registerBindingsOn: aBindingGroup
 	HLToolCommand 
 		registerConcreteClassesOn: aBindingGroup 

Some files were not shown because too many files changed in this diff