Browse Source

Prevent widgets from registering bindings twice

Nicolas Petton 11 years ago
parent
commit
407626e8c2
3 changed files with 7 additions and 11 deletions
  1. 3 4
      js/Helios-Core.deploy.js
  2. 4 5
      js/Helios-Core.js
  3. 0 2
      st/Helios-Core.st

+ 3 - 4
js/Helios-Core.deploy.js

@@ -358,13 +358,12 @@ smalltalk.method({
 selector: "renderOn:",
 fn: function (html){
 var self=this;
-return smalltalk.withContext(function($ctx1) { 
_st(self)._registerBindings();
-self["@wrapper"]=_st(html)._div();
+return smalltalk.withContext(function($ctx1) { 
self["@wrapper"]=_st(html)._div();
 _st((function(renderer){
 return smalltalk.withContext(function($ctx2) {
return _st(self)._renderContentOn_(renderer);
 }, function($ctx2) {$ctx2.fillBlock({renderer:renderer},$ctx1)})}))._appendToJQuery_(_st(self["@wrapper"])._asJQuery());
-return self}, function($ctx1) {$ctx1.fill(self,"renderOn:",{html:html}, smalltalk.HLWidget)})},
-messageSends: ["registerBindings", "div", "appendToJQuery:", "asJQuery", "renderContentOn:"]}),
+return self}, function($ctx1) {$ctx1.fill(self,"renderOn:",{html:html},smalltalk.HLWidget)})},
+messageSends: ["div", "appendToJQuery:", "asJQuery", "renderContentOn:"]}),
 smalltalk.HLWidget);
 
 smalltalk.addMethod(

+ 4 - 5
js/Helios-Core.js

@@ -484,15 +484,14 @@ selector: "renderOn:",
 category: 'rendering',
 fn: function (html){
 var self=this;
-return smalltalk.withContext(function($ctx1) { 
_st(self)._registerBindings();
-self["@wrapper"]=_st(html)._div();
+return smalltalk.withContext(function($ctx1) { 
self["@wrapper"]=_st(html)._div();
 _st((function(renderer){
 return smalltalk.withContext(function($ctx2) {
return _st(self)._renderContentOn_(renderer);
 }, function($ctx2) {$ctx2.fillBlock({renderer:renderer},$ctx1)})}))._appendToJQuery_(_st(self["@wrapper"])._asJQuery());
-return self}, function($ctx1) {$ctx1.fill(self,"renderOn:",{html:html}, smalltalk.HLWidget)})},
+return self}, function($ctx1) {$ctx1.fill(self,"renderOn:",{html:html},smalltalk.HLWidget)})},
 args: ["html"],
-source: "renderOn: html\x0a    self registerBindings.\x0a\x0a\x09wrapper := html div.\x0a    [ :renderer | self renderContentOn: renderer ] appendToJQuery: wrapper asJQuery",
-messageSends: ["registerBindings", "div", "appendToJQuery:", "asJQuery", "renderContentOn:"],
+source: "renderOn: html\x0a\x09wrapper := html div.\x0a    [ :renderer | self renderContentOn: renderer ] appendToJQuery: wrapper asJQuery",
+messageSends: ["div", "appendToJQuery:", "asJQuery", "renderContentOn:"],
 referencedClasses: []
 }),
 smalltalk.HLWidget);

+ 0 - 2
st/Helios-Core.st

@@ -135,8 +135,6 @@ renderContentOn: html
 !
 
 renderOn: html
-    self registerBindings.
-
 	wrapper := html div.
     [ :renderer | self renderContentOn: renderer ] appendToJQuery: wrapper asJQuery
 ! !