Home Verkennen Help
Registreren Inloggen
amber
/
helios
2
1
Vork 4
Bestanden Issues 30 Pull-aanvragen 0 Wiki
Labels Mijlpalen
Nieuw probleem

#76 Display a shortcut suggestion when launching a command from one of the browser panel's menu

Open
7 jaren geleden werd geopend door stevenremot · 3 opmerkingen
Steven Rémot reageerde 7 jaren geleden

This is the ticket that follow the discussion on #11.

It is about displaying a short-lived notice when a user triggers a command from one of the browser's panel to inform him there are keyboard shortcuts for it.

I started working on it on my fork: https://lolg.it/stevenremot/helios/src/shortcut-notice

Currently I trigger it from HLWidget>>#execute: because this method is not used when one triggers a command from the keyboard. However I'm not sure that's the right thing to do...

On the UX side, I tried both HLWidget>>#inform and creating a subclass of HLModalWidget that behaves like a short-lived suggestion. However, none of them satisfy me:

  • HLWidget>>#inform uses a suggestion that's considered to be a simple text, withtout any formatting possible. A pharo-like suggestion has two parts: the name and the command, and the shortcut
  • HLModalWidget is too big, I fear it gets in the way of the user. I don't think it's suited for this kind of bonus suggestion...

What do you think?

This is the ticket that follow the discussion on #11. It is about displaying a short-lived notice when a user triggers a command from one of the browser's panel to inform him there are keyboard shortcuts for it. I started working on it on my fork: https://lolg.it/stevenremot/helios/src/shortcut-notice Currently I trigger it from HLWidget>>#execute: because this method is not used when one triggers a command from the keyboard. However I'm not sure that's the right thing to do... On the UX side, I tried both HLWidget>>#inform and creating a subclass of HLModalWidget that behaves like a short-lived suggestion. However, none of them satisfy me: * HLWidget>>#inform uses a suggestion that's considered to be a simple text, withtout any formatting possible. A pharo-like suggestion has two parts: the name and the command, and the shortcut * HLModalWidget is too big, I fear it gets in the way of the user. I don't think it's suited for this kind of bonus suggestion... What do you think?
Herby Vojčík reageerde 7 jaren geleden
Eigenaar

I am not familiar with Helios code enough (@NicolasPetton is one who basically did Helios), but I would be UX consistent with the thing Compiler recompileAll uses to show progress bars of class compilation (ideally reusing it or find out if there isn't one just showing text, not the progress bar).

I am not familiar with Helios code enough (@NicolasPetton is one who basically did Helios), but I would be UX consistent with the thing `Compiler recompileAll` uses to show progress bars of class compilation (ideally reusing it or find out if there isn't one just showing text, not the progress bar).
Steven Rémot reageerde 7 jaren geleden
Poster

I advanced a bit on the subject. First I could restructure a bit my code to make it cleaner. Second, I replaced the growl notification with a proper HLModalWidget to be consistent with the compiler notification.

I came accross different problems when doing it. At first I was displaying my modal at the same time the context menu action was executed. However it conflicts with actions that requires some input from the user, there is one modal on top of another.

So I started trying to display the shortcut suggestion after the action finishes executing, like Pharo does. But the HLCommand and HLBinding system wasn't ready for this (the actions have asynchronous code, so I have to add callbacks everywhere).

To conclude, I have the feeling that's starting to be to much for a shortcut suggestion. It doesn't worth it to me. Maybe this should be solved by a future documentation effort, or something like that.

What do you think?

I advanced a bit on the subject. First I could restructure a bit my code to make it cleaner. Second, I replaced the growl notification with a proper HLModalWidget to be consistent with the compiler notification. I came accross different problems when doing it. At first I was displaying my modal at the same time the context menu action was executed. However it conflicts with actions that requires some input from the user, there is one modal on top of another. So I started trying to display the shortcut suggestion after the action finishes executing, like Pharo does. But the HLCommand and HLBinding system wasn't ready for this (the actions have asynchronous code, so I have to add callbacks everywhere). To conclude, I have the feeling that's starting to be to much for a shortcut suggestion. It doesn't worth it to me. Maybe this should be solved by a future documentation effort, or something like that. What do you think?
Herby Vojčík reageerde 7 jaren geleden
Eigenaar

I don't know... if it is hard to do, then, bad luck, there won't be one until things that are problematic in design are fixed...

I don't know... if it is hard to do, then, bad luck, there won't be one until things that are problematic in design are fixed...
Sign in to join this conversation.
Labels
Verwijder labels
Geen label
Mijlpaal
Verwijder mijlpaal
Geen mijlpaal
Toegewezen aan
Verwijder verantwoordelijke
Geen verantwoordelijke
2 deelnemers
Schrijf Voorbeeld
Laden...
Annuleren
Opslaan
Er is nog geen inhoud.