2 Commits e3879d09bf ... 1086251d9e

Author SHA1 Message Date
  Mariano Montone 1086251d9e Categorize methods in "Find references" commands 3 years ago
  Mariano Montone 0055c7db96 Revert "Make browseIt action invoke Finder" 3 years ago
4 changed files with 27 additions and 19 deletions
  1. 8 8
      src/Helios-Commands-Tools.js
  2. 14 6
      src/Helios-Commands-Tools.st
  3. 4 4
      src/Helios-Workspace.js
  4. 1 1
      src/Helios-Workspace.st

+ 8 - 8
src/Helios-Commands-Tools.js

@@ -770,7 +770,7 @@ $core.addClass("HLFindClassReferencesCommand", $globals.HLFindCommand, "Helios-C
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "category",
 selector: "category",
-protocol: "as yet unclassified",
+protocol: "accessing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "category\x0a\x09^ 'Classes'",
 source: "category\x0a\x09^ 'Classes'",
@@ -788,7 +788,7 @@ $globals.HLFindClassReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "execute",
 selector: "execute",
-protocol: "as yet unclassified",
+protocol: "executing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "execute\x0a\x0a\x09HLReferences new \x0a\x09\x09openAsTab;\x0a\x09\x09search: self model selectedClass theNonMetaClass name",
 source: "execute\x0a\x0a\x09HLReferences new \x0a\x09\x09openAsTab;\x0a\x09\x09search: self model selectedClass theNonMetaClass name",
@@ -815,7 +815,7 @@ $globals.HLFindClassReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "isActive",
 selector: "isActive",
-protocol: "as yet unclassified",
+protocol: "testing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "isActive\x0a\x09^ self model selectedClass notNil",
 source: "isActive\x0a\x09^ self model selectedClass notNil",
@@ -838,7 +838,7 @@ $globals.HLFindClassReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "isInputRequired",
 selector: "isInputRequired",
-protocol: "as yet unclassified",
+protocol: "testing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "isInputRequired\x0a\x09^ false",
 source: "isInputRequired\x0a\x09^ false",
@@ -877,7 +877,7 @@ $core.addClass("HLFindMethodReferencesCommand", $globals.HLFindCommand, "Helios-
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "category",
 selector: "category",
-protocol: "as yet unclassified",
+protocol: "accessing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "category\x0a\x09^ 'Methods'",
 source: "category\x0a\x09^ 'Methods'",
@@ -895,7 +895,7 @@ $globals.HLFindMethodReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "execute",
 selector: "execute",
-protocol: "as yet unclassified",
+protocol: "executing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "execute\x0a\x0a\x09HLReferences new \x0a\x09\x09openAsTab;\x0a\x09\x09search: self model selectedMethod selector",
 source: "execute\x0a\x0a\x09HLReferences new \x0a\x09\x09openAsTab;\x0a\x09\x09search: self model selectedMethod selector",
@@ -922,7 +922,7 @@ $globals.HLFindMethodReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "isActive",
 selector: "isActive",
-protocol: "as yet unclassified",
+protocol: "testing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "isActive\x0a\x09^ self model selectedMethod notNil",
 source: "isActive\x0a\x09^ self model selectedMethod notNil",
@@ -945,7 +945,7 @@ $globals.HLFindMethodReferencesCommand);
 $core.addMethod(
 $core.addMethod(
 $core.method({
 $core.method({
 selector: "isInputRequired",
 selector: "isInputRequired",
-protocol: "as yet unclassified",
+protocol: "testing",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
 source: "isInputRequired\x0a\x09^ false",
 source: "isInputRequired\x0a\x09^ false",

+ 14 - 6
src/Helios-Commands-Tools.st

@@ -229,18 +229,22 @@ HLFindCommand subclass: #HLFindClassReferencesCommand
 	slots: {}
 	slots: {}
 	package: 'Helios-Commands-Tools'!
 	package: 'Helios-Commands-Tools'!
 
 
-!HLFindClassReferencesCommand methodsFor: 'as yet unclassified'!
+!HLFindClassReferencesCommand methodsFor: 'accessing'!
 
 
 category
 category
 	^ 'Classes'
 	^ 'Classes'
-!
+! !
+
+!HLFindClassReferencesCommand methodsFor: 'executing'!
 
 
 execute
 execute
 
 
 	HLReferences new 
 	HLReferences new 
 		openAsTab;
 		openAsTab;
 		search: self model selectedClass theNonMetaClass name
 		search: self model selectedClass theNonMetaClass name
-!
+! !
+
+!HLFindClassReferencesCommand methodsFor: 'testing'!
 
 
 isActive
 isActive
 	^ self model selectedClass notNil
 	^ self model selectedClass notNil
@@ -260,18 +264,22 @@ HLFindCommand subclass: #HLFindMethodReferencesCommand
 	slots: {}
 	slots: {}
 	package: 'Helios-Commands-Tools'!
 	package: 'Helios-Commands-Tools'!
 
 
-!HLFindMethodReferencesCommand methodsFor: 'as yet unclassified'!
+!HLFindMethodReferencesCommand methodsFor: 'accessing'!
 
 
 category
 category
 	^ 'Methods'
 	^ 'Methods'
-!
+! !
+
+!HLFindMethodReferencesCommand methodsFor: 'executing'!
 
 
 execute
 execute
 
 
 	HLReferences new 
 	HLReferences new 
 		openAsTab;
 		openAsTab;
 		search: self model selectedMethod selector
 		search: self model selectedMethod selector
-!
+! !
+
+!HLFindMethodReferencesCommand methodsFor: 'testing'!
 
 
 isActive
 isActive
 	^ self model selectedMethod notNil
 	^ self model selectedMethod notNil

+ 4 - 4
src/Helios-Workspace.js

@@ -321,11 +321,11 @@ selector: "browseIt",
 protocol: "actions",
 protocol: "actions",
 //>>excludeStart("ide", pragmas.excludeIdeData);
 //>>excludeStart("ide", pragmas.excludeIdeData);
 args: [],
 args: [],
-source: "browseIt\x0a\x09[ Finder findString: self currentLineOrSelection ] fork",
-referencedClasses: ["Finder"],
+source: "browseIt\x0a\x09[ self model browse: self basicDoIt ] fork",
+referencedClasses: [],
 //>>excludeEnd("ide");
 //>>excludeEnd("ide");
 pragmas: [],
 pragmas: [],
-messageSends: ["fork", "findString:", "currentLineOrSelection"]
+messageSends: ["fork", "browse:", "model", "basicDoIt"]
 }, function ($methodClass){ return function (){
 }, function ($methodClass){ return function (){
 var self=this,$self=this;
 var self=this,$self=this;
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
@@ -335,7 +335,7 @@ $recv((function(){
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
 return $core.withContext(function($ctx2) {
 return $core.withContext(function($ctx2) {
 //>>excludeEnd("ctx");
 //>>excludeEnd("ctx");
-return $recv($globals.Finder)._findString_($self._currentLineOrSelection());
+return $recv($self._model())._browse_($self._basicDoIt());
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
 //>>excludeStart("ctx", pragmas.excludeDebugContexts);
 }, function($ctx2) {$ctx2.fillBlock({},$ctx1,1)});
 }, function($ctx2) {$ctx2.fillBlock({},$ctx1,1)});
 //>>excludeEnd("ctx");
 //>>excludeEnd("ctx");

+ 1 - 1
src/Helios-Workspace.st

@@ -148,7 +148,7 @@ basicDoIt
 !
 !
 
 
 browseIt
 browseIt
-	[ Finder findString: self currentLineOrSelection ] fork
+	[ self model browse: self basicDoIt ] fork
 !
 !
 
 
 clear
 clear