Home Explore Help
Register Sign In
amber
/
helios
2
1
Fork 4
Files Issues 30 Pull Requests 0 Wiki
Labels Milestones
New Issue

#59 Use jQuery on instead of javascript onunload

Closed
opened 8 years ago by nero · 0 comments
Admin of lolg.it commented 8 years ago

Originally at 2015-02-19T09:50:54Z by Ryan Simmons closed at 2015-02-19T11:23:40Z (pull request)

@herby, sorry I found a bug on my previous commit.

If you popup Helios, then close it and popup Helios a second time it will not close on the parent unload event. It appears calling onunload: multiple times does not work.

I have changed it to rather use jQuery on: do: and can confirm that the bug is no longer present.

Originally at 2015-02-19T09:50:54Z by Ryan Simmons closed at 2015-02-19T11:23:40Z (pull request) @herby, sorry I found a bug on my previous commit. If you popup Helios, then close it and popup Helios a second time it will not close on the parent unload event. It appears calling onunload: multiple times does not work. I have changed it to rather use jQuery on: do: and can confirm that the bug is no longer present.
nero closed 7 years ago
Sign in to join this conversation.
Labels
Clear labels
No Label
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
1 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.