Home Verkennen Help
Registreren Inloggen
amber
/
helios
2
1
Vork 4
Bestanden Issues 30 Pull-aanvragen 0 Wiki
Labels Mijlpalen
Nieuw probleem

#59 Use jQuery on instead of javascript onunload

Gesloten
8 jaren geleden werd geopend door nero · 0 opmerkingen
Admin of lolg.it reageerde 8 jaren geleden

Originally at 2015-02-19T09:50:54Z by Ryan Simmons closed at 2015-02-19T11:23:40Z (pull request)

@herby, sorry I found a bug on my previous commit.

If you popup Helios, then close it and popup Helios a second time it will not close on the parent unload event. It appears calling onunload: multiple times does not work.

I have changed it to rather use jQuery on: do: and can confirm that the bug is no longer present.

Originally at 2015-02-19T09:50:54Z by Ryan Simmons closed at 2015-02-19T11:23:40Z (pull request) @herby, sorry I found a bug on my previous commit. If you popup Helios, then close it and popup Helios a second time it will not close on the parent unload event. It appears calling onunload: multiple times does not work. I have changed it to rather use jQuery on: do: and can confirm that the bug is no longer present.
nero gesloten om 7 jaren geleden
Sign in to join this conversation.
Labels
Verwijder labels
Geen label
Mijlpaal
Verwijder mijlpaal
Geen mijlpaal
Toegewezen aan
Verwijder verantwoordelijke
Geen verantwoordelijke
1 deelnemers
Schrijf Voorbeeld
Laden...
Annuleren
Opslaan
Er is nog geen inhoud.