#80 Navigation features

Обединени
herby обедини 3 ревизии от mmontone/master във amber/master преди 2 години
mmontone коментира преди 2 години

Hello.

I've implemented some navigation features that I found handy.

  • Find references commands in menus.
  • Browse it supports method names.
  • Open panel menu on right click.
  • Browse selected method from debugger call stack.

Feel free to do whatever you want with these. Modify them, or discard them completely.

Cheers!

Hello. I've implemented some navigation features that I found handy. * Find references commands in menus. * Browse it supports method names. * Open panel menu on right click. * Browse selected method from debugger call stack. Feel free to do whatever you want with these. Modify them, or discard them completely. Cheers!
Herby Vojčík коментира преди 2 години
Притежател

Are the methods in other Helios command classes also in 'as yet unclassified' protocol? If not, please, categorize your ones, too. :-)

(and if possible, not by other commits, but fixing old one via rebase)

Are the methods in other Helios command classes also in 'as yet unclassified' protocol? If not, please, categorize your ones, too. :-) (and if possible, not by other commits, but fixing old one via rebase)
Herby Vojčík коментира преди 2 години
Притежател

Re: browseIt change - I would like not to have it there... browseIt is the same as printIt or inspectIt - it should first evaluate the selection, then try to show the result of evaluation in browser.

After all, I presume Ctrl+click does this job, so browseIt can stay with its 'evaluate and browse the result' semantics.

(speaking of Ctrl+click: amber/amber#1263)

Re: browseIt change - I would like not to have it there... browseIt is the same as printIt or inspectIt - it _should_ first evaluate the selection, then try to show the result of evaluation in browser. After all, I presume Ctrl+click does this job, so browseIt can stay with its 'evaluate and browse the result' semantics. (speaking of Ctrl+click: https://lolg.it/amber/amber/issues/1263)
Herby Vojčík коментира преди 2 години
Притежател

If you added context menu on right-click on every pane (not sure, probably yes), then add "Fixes #11" to the commit message.

If you added context menu on right-click on every pane (not sure, probably yes), then add "Fixes #11" to the commit message.
mmontone коментира преди 2 години
Участник

I've reverted the "browseIt" change and categorized the methods in new commands.

I've done it all with new commits, though. As my git rebase abilities are null but for the most basic changes at the moment :/ .

And so, I couldn't change the commit message for the right click on panels commit (yes, right click opens panels menu for every panel, when an item is selected). (perhaps you can reference the commit from the issue instead?)

Sorry, this is the best I can do at the moment.

I've reverted the "browseIt" change and categorized the methods in new commands. I've done it all with new commits, though. As my git rebase abilities are null but for the most basic changes at the moment :/ . And so, I couldn't change the commit message for the right click on panels commit (yes, right click opens panels menu for every panel, when an item is selected). (perhaps you can reference the commit from the issue instead?) Sorry, this is the best I can do at the moment.
mmontone коментира преди 2 години
Участник

I think I've managed to rebase and apply everything you've requested now.

I think I've managed to rebase and apply everything you've requested now.
Herby Vojčík коментира преди 2 години
Притежател

Nice.

One more small thing pls: the class level menuLabel methods are still not classified. :-) Could you fix (and get it back to the original commit as the fixup)? Thanks.

Nice. One more small thing pls: the class level `menuLabel` methods are still not classified. :-) Could you fix (and get it back to the original commit as the fixup)? Thanks.
mmontone коментира преди 2 години
Участник

Done

Done
Herby Vojčík коментира преди 2 години
Притежател

Since helios is hardly separable from Amber, add yourself into https://lolg.it/amber/amber/src/master/CONTRIBUTORS, pls; via PR.

Since helios is hardly separable from Amber, add yourself into https://lolg.it/amber/amber/src/master/CONTRIBUTORS, pls; via PR.
Herby Vojčík коментира преди 2 години
Притежател

It seems the "Fixes #11" should have been added to the main line... gogs didn't get it from the literary part. :-(

It seems the "Fixes #11" should have been added to the main line... gogs didn't get it from the literary part. :-(
Тази заявка за сливане е обединена успешно!
Впишете се за да се присъедините към разговора.
Няма етикет
Няма етап
Няма изпълнител
2 участника
Зареждане...
Отказ
Запис
Все още няма съдържание.