#80 Navigation features

병합
herby mmontone/master 에서 amber/master 로 3 commits 를 머지했습니다 2 년 전
mmontone 코멘트됨, 2 년 전

Hello.

I've implemented some navigation features that I found handy.

  • Find references commands in menus.
  • Browse it supports method names.
  • Open panel menu on right click.
  • Browse selected method from debugger call stack.

Feel free to do whatever you want with these. Modify them, or discard them completely.

Cheers!

Hello. I've implemented some navigation features that I found handy. * Find references commands in menus. * Browse it supports method names. * Open panel menu on right click. * Browse selected method from debugger call stack. Feel free to do whatever you want with these. Modify them, or discard them completely. Cheers!
Herby Vojčík 코멘트됨, 2 년 전
소유자

Are the methods in other Helios command classes also in 'as yet unclassified' protocol? If not, please, categorize your ones, too. :-)

(and if possible, not by other commits, but fixing old one via rebase)

Are the methods in other Helios command classes also in 'as yet unclassified' protocol? If not, please, categorize your ones, too. :-) (and if possible, not by other commits, but fixing old one via rebase)
Herby Vojčík 코멘트됨, 2 년 전
소유자

Re: browseIt change - I would like not to have it there... browseIt is the same as printIt or inspectIt - it should first evaluate the selection, then try to show the result of evaluation in browser.

After all, I presume Ctrl+click does this job, so browseIt can stay with its 'evaluate and browse the result' semantics.

(speaking of Ctrl+click: amber/amber#1263)

Re: browseIt change - I would like not to have it there... browseIt is the same as printIt or inspectIt - it _should_ first evaluate the selection, then try to show the result of evaluation in browser. After all, I presume Ctrl+click does this job, so browseIt can stay with its 'evaluate and browse the result' semantics. (speaking of Ctrl+click: https://lolg.it/amber/amber/issues/1263)
Herby Vojčík 코멘트됨, 2 년 전
소유자

If you added context menu on right-click on every pane (not sure, probably yes), then add "Fixes #11" to the commit message.

If you added context menu on right-click on every pane (not sure, probably yes), then add "Fixes #11" to the commit message.
mmontone 코멘트됨, 2 년 전
포스터

I've reverted the "browseIt" change and categorized the methods in new commands.

I've done it all with new commits, though. As my git rebase abilities are null but for the most basic changes at the moment :/ .

And so, I couldn't change the commit message for the right click on panels commit (yes, right click opens panels menu for every panel, when an item is selected). (perhaps you can reference the commit from the issue instead?)

Sorry, this is the best I can do at the moment.

I've reverted the "browseIt" change and categorized the methods in new commands. I've done it all with new commits, though. As my git rebase abilities are null but for the most basic changes at the moment :/ . And so, I couldn't change the commit message for the right click on panels commit (yes, right click opens panels menu for every panel, when an item is selected). (perhaps you can reference the commit from the issue instead?) Sorry, this is the best I can do at the moment.
mmontone 코멘트됨, 2 년 전
포스터

I think I've managed to rebase and apply everything you've requested now.

I think I've managed to rebase and apply everything you've requested now.
Herby Vojčík 코멘트됨, 2 년 전
소유자

Nice.

One more small thing pls: the class level menuLabel methods are still not classified. :-) Could you fix (and get it back to the original commit as the fixup)? Thanks.

Nice. One more small thing pls: the class level `menuLabel` methods are still not classified. :-) Could you fix (and get it back to the original commit as the fixup)? Thanks.
mmontone 코멘트됨, 2 년 전
포스터

Done

Done
herby 2 년 전가 Close
Herby Vojčík 코멘트됨, 2 년 전
소유자

Since helios is hardly separable from Amber, add yourself into https://lolg.it/amber/amber/src/master/CONTRIBUTORS, pls; via PR.

Since helios is hardly separable from Amber, add yourself into https://lolg.it/amber/amber/src/master/CONTRIBUTORS, pls; via PR.
Herby Vojčík 코멘트됨, 2 년 전
소유자

It seems the "Fixes #11" should have been added to the main line... gogs didn't get it from the literary part. :-(

It seems the "Fixes #11" should have been added to the main line... gogs didn't get it from the literary part. :-(
이 풀리퀘스트가 성공적으로 머지되었습니다!
로그인하여 이 대화에 참여
레이블 없음
마일스톤 없음
담당자 없음
참여자 2명
로딩중...
취소
저장
아직 콘텐츠가 없습니다.